fix: Fix PHP Warning foreach() argument must be of type array|object, null given#61245
Merged
Conversation
… null given Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
requested review from
Altahrim,
ArtificialOwl and
leftybournes
and removed request for
a team
Contributor
Author
|
/backport to stable34 |
come-nc
added
3. to review
nickvergessen
approved these changes
Jun 12, 2026
joshtrichards
approved these changes
Jun 12, 2026
| $item = $item->getParent(); | ||
|
|
||
| if ($byId[$item->getId()] !== []) { | ||
| if (isset($byId[$item->getId()]) && $byId[$item->getId()] !== []) { |
Member
There was a problem hiding this comment.
Suggested change
| if (isset($byId[$item->getId()]) && $byId[$item->getId()] !== []) { | |
| if (isset($byId[$item->getId()])) { |
Should be enough I think (and more consistent with existing logic above)
| while (!empty($byId)) { | ||
| try { | ||
| if ($byId[$item->getId()] !== []) { | ||
| if (isset($byId[$item->getId()]) && $byId[$item->getId()] !== []) { |
Member
There was a problem hiding this comment.
Suggested change
| if (isset($byId[$item->getId()]) && $byId[$item->getId()] !== []) { | |
| if (isset($byId[$item->getId()])) { |
Same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
3. to review, feature component)stable32)AI (if applicable)